Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Castle.Core target frameworks vs Castle.Windsor #564

Closed
generik0 opened this issue Nov 18, 2020 · 4 comments · Fixed by #572
Closed

Castle.Core target frameworks vs Castle.Windsor #564

generik0 opened this issue Nov 18, 2020 · 4 comments · Fixed by #572
Milestone

Comments

@generik0
Copy link
Contributor

generik0 commented Nov 18, 2020

Hi @jonorossi

The Castle.Core target references are:
<TargetFrameworks>net45;netstandard2.0;netstandard2.1</TargetFrameworks>

Should we align Castle.Windsor against Castle.Core?

Even better:

<TargetFrameworks>net45;netstandard2.0;net5.0</TargetFrameworks>

?

@generik0 generik0 reopened this Nov 18, 2020
@jonorossi
Copy link
Member

I think this one will need to wait a bit. Castle.Core target frameworks in master are newer than the last release, we've not yet got to release Castle.Core 5.0.

  • 4.4.1: net35;net40;net45;netstandard1.3;netstandard1.5
  • master: net45;netstandard2.0;netstandard2.1

Now that net5.0 is out, we'll add that and probably drop ns2.1.

@generik0
Copy link
Contributor Author

@jonorossi please review PR whne you have time. Castle.Windsor looks ready to update target frameworks

generik0 added a commit to generik0/Windsor that referenced this issue Nov 26, 2020
generik0 added a commit to generik0/Windsor that referenced this issue Nov 29, 2020
generik0 added a commit to generik0/Windsor that referenced this issue Nov 29, 2020
generik0 added a commit to generik0/Windsor that referenced this issue Dec 7, 2020
generik0 added a commit to generik0/Windsor that referenced this issue Dec 7, 2020
generik0 added a commit to generik0/Windsor that referenced this issue Dec 7, 2020
generik0 added a commit to generik0/Windsor that referenced this issue Dec 7, 2020
@lg2de
Copy link

lg2de commented Dec 8, 2020

Now that net5.0 is out, we'll add that and probably drop ns2.1.

netstandard2.1 is used if referenced from dotnetcoreapp3.1. If you remove ns2.1 and add net5.0 you will not support dotnetcore 3.1. But 3.1 is LTS, net5.0 is NOT LTS.

@jonorossi
Copy link
Member

If you remove ns2.1 and add net5.0 you will not support dotnetcore 3.1. But 3.1 is LTS, net5.0 is NOT LTS.

Windsor today targets net45;netstandard1.6, so "dropping" ns2.1 in my comment was from the proposed list which @generik0 posted (since it isn't implemented), which would leave the new proposed list net45;netstandard2.0;net5.0.

Anyway, these comments are old compared to the discussion on the pull request.

generik0 added a commit to generik0/Windsor that referenced this issue Dec 9, 2020
generik0 added a commit to generik0/Windsor that referenced this issue Dec 9, 2020
generik0 added a commit to generik0/Windsor that referenced this issue Dec 9, 2020
@jonorossi jonorossi added this to the vNext milestone Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants