Castle.Windsor.Extensions.DependencyInjection Cleanup

[generik0]

Hi @jonorossi and @ltines.

I went through the Castle.Windsor.Extensions.DependencyInjection with a fine come and cleaned up.
Do you want the refactoring?
I will make a PR

[generik0]

Hi.
This branch is important because I found unused methods, fields. And in general some things needed cleaning up ;-)

[generik0]

@ltines i have noticed that

Windsor/src/Castle.Windsor.Extensions.DependencyInjection/Scope/ExtensionContainerRootScope.cs

Line 19 in 8a7d927

internal static ExtensionContainerRootScope RootScope {get; private set;}

Has a static var used to keep the root scope?

Are we sure using static isn't anti-OO / not SOLID?
Could something else be used? Maybe get the logic out of an extension to a class instance?

[ltines]

@generik0 the root scope is there so singleton instances can be linked to a scope with explicit Dispose (.NET expects singletons to be disposed on dispose of "outermost" ServiceProvider

[generik0]

Hi @ltines
Yes I understand that. I just think it might be a little anti IOC/ anti pattern exposing a internal static prop for a class.
I have tried to figure out an alternative, but cannot...

[generik0]

@jonorossi i will close this. The current implementation is good enough