Simplify SimpleAST by converting Expression, Statement to interfaces
#566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
force-pushed
the
simple-ast
branch
2 times, most recently
from
cd9448d to
e656530
Compare
jonorossi
approved these changes
Feb 3, 2021
Member
jonorossi
left a comment
jonorossi
left a comment
There was a problem hiding this comment.
Looks great. That definitely tidies up the code, especially that the stack based runtime rarely cares about the difference between C# level statements and expressions.
| using System.Reflection.Emit; | ||
|
|
||
| internal class MultiStatementExpression : Expression | ||
| internal class BlockStatement : IStatement |
Member
There was a problem hiding this comment.
MultiStatementExpression, haha, yer that shows things were not quite right 👍
src/Castle.Core/DynamicProxy/Generators/Emitters/SimpleAST/Reference.cs
Outdated
Show resolved
Hide resolved
Now that `IExpression` and `IStatement` are interfaces, AST nodes like e.g. `MethodInvocationExpression` can be both at the same time, so there is no more need to bridge the two types with `ExpressionStatement`.
because `Reference` can simply implement `IExpression` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpressionStatementis an adapter type that turns anExpressioninto aStatement. Its mere existence demonstrates that a strict distinction between expressions and statements is more of a stumbling block than it is helpful. Some AST node types (such asMethodInvocationExpression) need to act as either.We can model this at the type system level by converting
ExpressionandStatementto interfaces. AST node types can then implement both interfaces, which renders adapter typesExpressionStatementandReferenceExpressionredundant. Removing those from AST trees means fewer allocations and thus slightly less GC pressure.Outlook
I'd like to follow this up with another PR that will introduce an interface
ILocationfor modelling storage locations. TheLoad/Storemethods ofReferencewould end up there. I expect this would both simplify by-ref handling and indirect loads / stores.