Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible documentation glitch: "!python: event not found" #55

Closed
spier opened this issue Mar 11, 2021 · 1 comment · Fixed by #56
Closed

Possible documentation glitch: "!python: event not found" #55

spier opened this issue Mar 11, 2021 · 1 comment · Fixed by #56
Assignees

Comments

@spier
Copy link
Contributor

spier commented Mar 11, 2021

Hi there,

I tried out this tool today, looks nice! :)

When installing this I ran into the following issue

$ git config --global alias.fame "!python -m gitfame"
-bash: !python: event not found

My environment:

  • OSX
  • bash

I was able to fix it by using single quotation marks i.e.

$ git config --global alias.fame '!python -m gitfame'

Not sure if that issue is reproducible by others?
Happy to send a PR for this but I figured I first confirm this with you.

Cheers :)

@casperdcl
Copy link
Owner

casperdcl commented Mar 11, 2021

ah yes, silly oversight on my part trying to support Windows. Yes, happy to accept a PR. Though... was it required at all?

As the comment just over the offending line states, it's probably not required on UNIX systems.

casperdcl added a commit to spier/git-fame that referenced this issue Mar 11, 2021
casperdcl added a commit to spier/git-fame that referenced this issue Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants