Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly unneeded code maintenance. #2

Open
ciscorucinski opened this issue Oct 29, 2020 · 2 comments
Open

Possibly unneeded code maintenance. #2

ciscorucinski opened this issue Oct 29, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@ciscorucinski
Copy link

Do you need to include all the other source code besides what Snap needs? Can't you get rid of everything and link the source code via URL in the yaml file? This repo is just for the snap, right?

Additional context

The Android Studio Snap is a good example of this as it grabs the latest url. The repo is really small and only deals with the snap.

@casperdcl casperdcl self-assigned this Dec 17, 2020
@casperdcl casperdcl added enhancement New feature or request question Further information is requested labels Dec 17, 2020
@casperdcl
Copy link
Owner

  1. the original intention was this fork to be a PR into the upstream repo
    • they've indicated they may still merge it at some point in the future
  2. the code is also automatically rebased onto the latest upstream version daily so stays up-to-date (minor versioning bug in Snap update to v1.3.1 #3 is fixed now)

@casperdcl
Copy link
Owner

casperdcl commented Dec 17, 2020

FYI for future ref, the approach in https://github.com/snapcrafters/android-studio/blob/1ec5cf5b3e19ca490b5529b162083cb4de15d8a1/get_latest.py and https://github.com/snapcrafters/android-studio/blob/1ec5cf5b3e19ca490b5529b162083cb4de15d8a1/snap/snapcraft.yaml#L32-L36 can be implemented here simply as:

curl -LO $(
  gh api 'repos/cli/cli/releases?per_page=1' |
  jq -r '.[].assets[].browser_download_url' |
  grep -E '.*linux.*amd64.*\.tar\.gz$')

casperdcl pushed a commit that referenced this issue Jun 30, 2021
casperdcl pushed a commit that referenced this issue Jun 30, 2021
casperdcl pushed a commit that referenced this issue Oct 1, 2021
Increase ssh command timeout and improve error message
casperdcl pushed a commit that referenced this issue Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants