(CD-90) Fix NCTL activate command and broken links #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiu-hong
reviewed
May 15, 2025
| * A [server-sent events (SSE) endpoint](https://github.com/casper-network/casper-sidecar/blob/feat-2.0/README.md#the-sse-server) with an `/events` endpoint streaming events from all the connected nodes. The Sidecar also stores these events. | ||
| * A [REST API server](https://github.com/casper-network/casper-sidecar/blob/feat-2.0/README.md#the-rest-api-server) that allows clients to query stored events. | ||
| * A [JSON-RPC API](https://github.com/casper-network/casper-sidecar/blob/feat-2.0/README.md#the-rpc-api-server) to interact with a Casper node. | ||
| * A [server-sent events (SSE) endpoint](https://github.com/casper-network/casper-sidecar/blob/release-1.0.2-rc8_node-2.0.0-rc8/README.md#the-sse-server) with an `/events` endpoint streaming events from all the connected nodes. The Sidecar also stores these events. |
There was a problem hiding this comment.
should sidecar's release be tag v1.0.4?
There was a problem hiding this comment.
Thanks, @Jiu-hong , I've incorporated the comments.
There was a problem hiding this comment.
command line output should include sidecar
There was a problem hiding this comment.
Thanks, @Jiu-hong , I've incorporated the comments.
devendran-m
added a commit
that referenced
this pull request
May 15, 2025
PR to merge PR #71 changes from `dev` to `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR will fix the following issues in the docs. Resolves JIRA CD-90.
In the current Docs's NCTL setup page here, there's a command in Step 16;
source casper-node/utils/nctl/activate. This should have beensource activate.The links in https://docs.casper.network/next/operators/setup/casper-sidecar page are broken. This PR fixes those broken links.