Handle purse not found error (#337)

rpc_sidecar/src/node_client.rs

@@ -627,6 +627,8 @@ pub enum Error {
     SwitchBlockParentNotFound,
     #[error("cannot serve rewards stored in V1 format")]
     UnsupportedRewardsV1Request,
+    #[error("purse was not found for given identifier")]
+    PurseNotFound,
     #[error("received a response with an unsupported protocol version: {0}")]
     UnsupportedProtocolVersion(ProtocolVersion),
     #[error("received an unexpected node error: {message} ({code})")]
@@ -645,6 +647,7 @@ impl Error {
             Ok(ErrorCode::SwitchBlockParentNotFound) => Self::SwitchBlockParentNotFound,
             Ok(ErrorCode::UnsupportedRewardsV1Request) => Self::UnsupportedRewardsV1Request,
             Ok(ErrorCode::BinaryProtocolVersionMismatch) => Self::BinaryProtocolVersionMismatch,
+            Ok(ErrorCode::PurseNotFound) => Self::PurseNotFound,
             Ok(
                 err @ (ErrorCode::InvalidDeployChainName
                 | ErrorCode::InvalidDeployDependenciesNoLongerSupported

rpc_sidecar/src/rpcs/error.rs

@@ -93,9 +93,10 @@ impl Error {
             Error::NodeRequest(_, NodeClientError::UnsupportedRewardsV1Request) => {
                 Some(ErrorCode::UnsupportedRewardsV1Request)
             }
+            Error::NodeRequest(_, NodeClientError::PurseNotFound) => Some(ErrorCode::PurseNotFound),
             Error::InvalidPurseURef(_) => Some(ErrorCode::FailedToParseGetBalanceURef),
             Error::InvalidDictionaryKey(_) => Some(ErrorCode::FailedToParseQueryKey),
-            Error::MainPurseNotFound => Some(ErrorCode::NoSuchMainPurse),
+            Error::MainPurseNotFound => Some(ErrorCode::NoMainPurse),
             Error::AccountNotFound => Some(ErrorCode::NoSuchAccount),
             Error::AddressableEntityNotFound => Some(ErrorCode::NoSuchAddressableEntity),
             Error::RewardNotFound => Some(ErrorCode::NoRewardsFound),

rpc_sidecar/src/rpcs/error_code.rs

@@ -36,7 +36,7 @@ pub enum ErrorCode {
     /// The requested state root hash was not found.
     NoSuchStateRoot = -32012,
     /// The main purse for a given account hash does not exist.
-    NoSuchMainPurse = -32013,
+    NoMainPurse = -32013,
     /// The requested Transaction was not found.
     NoSuchTransaction = -32014,
     /// Variant mismatch.
@@ -61,6 +61,8 @@ pub enum ErrorCode {
     SwitchBlockParentNotFound = -32024,
     /// Cannot serve rewards stored in V1 format
     UnsupportedRewardsV1Request = -32025,
+    /// Purse was not found for given identifier.
+    PurseNotFound = -32026,
 }
 
 impl From<ErrorCode> for (i64, &'static str) {
@@ -85,7 +87,7 @@ impl From<ErrorCode> for (i64, &'static str) {
             }
             ErrorCode::FailedToGetTrie => (error_code as i64, "Failed to get trie"),
             ErrorCode::NoSuchStateRoot => (error_code as i64, "No such state root"),
-            ErrorCode::NoSuchMainPurse => (error_code as i64, "Failed to get main purse"),
+            ErrorCode::NoMainPurse => (error_code as i64, "Failed to get main purse"),
             ErrorCode::NoSuchTransaction => (error_code as i64, "No such transaction"),
             ErrorCode::VariantMismatch => (error_code as i64, "Variant mismatch internal error"),
             ErrorCode::InvalidTransaction => (error_code as i64, "Invalid transaction"),
@@ -109,6 +111,7 @@ impl From<ErrorCode> for (i64, &'static str) {
                 error_code as i64,
                 "Cannot serve rewards stored in V1 format",
             ),
+            ErrorCode::PurseNotFound => (error_code as i64, "Purse not found"),
         }
     }
 }

rpc_sidecar/src/rpcs/state.rs

@@ -1147,8 +1147,8 @@ mod tests {
     use crate::{rpcs::ErrorCode, ClientError, SUPPORTED_PROTOCOL_VERSION};
     use casper_binary_port::{
         BalanceResponse, BinaryRequest, BinaryResponse, BinaryResponseAndRequest,
-        DictionaryQueryResult, GetRequest, GlobalStateQueryResult, GlobalStateRequest,
-        InformationRequestTag, KeyPrefix,
+        DictionaryQueryResult, ErrorCode as BinaryErrorCode, GetRequest, GlobalStateQueryResult,
+        GlobalStateRequest, InformationRequestTag, KeyPrefix,
     };
     use casper_types::{
         addressable_entity::{MessageTopics, NamedKeyValue, NamedKeys},
@@ -1233,6 +1233,23 @@ mod tests {
         );
     }
 
+    #[tokio::test]
+    async fn should_handle_balance_not_found() {
+        let rng = &mut TestRng::new();
+
+        let err = GetBalance::do_handle_request(
+            Arc::new(BalancePurseNotFoundMock),
+            GetBalanceParams {
+                state_root_hash: rng.gen(),
+                purse_uref: URef::new(rng.gen(), AccessRights::empty()).to_formatted_string(),
+            },
+        )
+        .await
+        .expect_err("should fail request");
+
+        assert_eq!(err.code(), ErrorCode::PurseNotFound as i64);
+    }
+
     #[tokio::test]
     async fn should_read_auction_info() {
         struct ClientMock {
@@ -2387,4 +2404,30 @@ mod tests {
             }
         }
     }
+
+    struct BalancePurseNotFoundMock;
+
+    #[async_trait]
+    impl NodeClient for BalancePurseNotFoundMock {
+        async fn send_request(
+            &self,
+            req: BinaryRequest,
+        ) -> Result<BinaryResponseAndRequest, ClientError> {
+            match req {
+                BinaryRequest::Get(GetRequest::State(req))
+                    if matches!(&*req, GlobalStateRequest::Balance { .. }) =>
+                {
+                    Ok(BinaryResponseAndRequest::new(
+                        BinaryResponse::new_error(
+                            BinaryErrorCode::PurseNotFound,
+                            SUPPORTED_PROTOCOL_VERSION,
+                        ),
+                        &[],
+                        0,
+                    ))
+                }
+                req => unimplemented!("unexpected request: {:?}", req),
+            }
+        }
+    }
 }