This repository was archived by the owner on May 11, 2025. It is now read-only.
Add computed position embedding external#705
Closed
seungwoos wants to merge 1 commit intocasper-hansen:mainfrom
Closed
Add computed position embedding external#705seungwoos wants to merge 1 commit intocasper-hansen:mainfrom
seungwoos wants to merge 1 commit intocasper-hansen:mainfrom
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest huggingface version requires pre-computed positional embeddings as a forward process argument. (huggingface<4.48.0 and huggingface>=4.48.0)
To handle this, I added
position_embeddingonmodule_kwargswhich contains a tuple of cos and sin.