followups on depends_on :macos/:arch
#7819
Merged
+54
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* always coerce `:macos` value to array; simplify code * remove warning comments about unset values * doc explicitly that requirements are covered as well as dependencies * doc that `depends_on` is not consulted until `install` time * in docs and code, say "release" instead of "version" for the :macos release * todo: provide our own variable styled "release" to use in Casks, instead of Homebrew's `MacOS.Version` * doc that symbols are preferred for `:macos` over strings in Casks (interally, all are converted to idential `Gem::Version` objects) * doc: remove `os_version_only` from `cask_language_deltas.md` * doc: improve internal links * doc: recast OS X release symbol list as table * doc: (incidental) regularize orthography of Formula and Cask
rolandwalker
added
the
core
rolandwalker
added a commit
that referenced
this pull request
Dec 6, 2014
followups on `depends_on` `:macos`/`:arch`
miccal
removed
the
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:macosvalue to array; simplify codedepends_onis not consulted untilinstalltimeMacOS.Version:macosover strings in Casks (interally, all are converted to identialGem::Versionobjects) refs: Convert 7 Casks todepends_on :macos#7760 (comment)os_version_onlyfromcask_language_deltas.md