Conversation
Also makes the templated project run in the monorepo.
chris-ryan-square
approved these changes
Aug 3, 2021
...to lessen the number of changes happening at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
miskweb new's dependence on the repo in future versions, which then allows us to make changes to this repo without those versions breaking.I've used node-plop here, which is a library version of plop.
.../plop-templates/basicis a copy ofexamples/starter-basic, but with the changes fromnew-tab-starter-basic.shapplied, and a few changes to use handlebars templates when possible.Will remove the current new-tab scripts after projects have been updated.