Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requires seems to slow down hermit exec by about 600ms #396

Closed
alecthomas opened this issue Mar 13, 2024 · 1 comment · Fixed by #431
Closed

requires seems to slow down hermit exec by about 600ms #396

alecthomas opened this issue Mar 13, 2024 · 1 comment · Fixed by #431

Comments

@alecthomas
Copy link
Collaborator

This line is the culprit. I haven't done any further investigation as to what is causing it though.
spicykay pushed a commit to spicykay/hermit that referenced this issue Aug 23, 2024
@Egorand
Add Gradle 8.4 (cashapp#396)
0907ac6
@nickajacks1
Copy link
Contributor

I dug a little deeper, and the reason it takes so long is that it loads every single package's hcl file here.

ResolveWithDeps calls resolveVirtual, which in turn examines all packages. hermit exec can probably limit its examination to what has already been installed.

@nickajacks1 nickajacks1 mentioned this issue Jan 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: speedup hermit exec nickajacks1/hermit
2 participants
@alecthomas @nickajacks1