Pass stdin handle to backtick process #409
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backtick processes are launched (via the
brev
crate) usingCommand::output
, which by default prevents stdin from being inherited.This diff passes stdin through. This allows backtick commands to read from stdin, and so fixes #376 and #374.
In particular, this allows:
To support this change, integration tests are modified to take an additional string argument, which is written to the
just
child process's stdin. Existing tests are passed""
, and a few tests have been added that read from stdin and echo it, to make sure that it actually works.cc: @slisznia