Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace derivative with derive-where #2465

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

laniakea64
Copy link
Contributor

Running cargo audit on just repo gives the following warnings -

Crate:     ansi_term
Version:   0.12.1
Warning:   unmaintained
Title:     ansi_term is Unmaintained
Date:      2021-08-18
ID:        RUSTSEC-2021-0139
URL:       https://rustsec.org/advisories/RUSTSEC-2021-0139
Dependency tree:
ansi_term 0.12.1
└── just 1.36.0

Crate:     derivative
Version:   2.2.0
Warning:   unmaintained
Title:     `derivative` is unmaintained; consider using an alternative
Date:      2024-06-26
ID:        RUSTSEC-2024-0388
URL:       https://rustsec.org/advisories/RUSTSEC-2024-0388
Dependency tree:
derivative 2.2.0
└── just 1.36.0

warning: 2 allowed warnings found

This PR fixes one of these two warnings by replacing derivative with derive-where, which is how rustc handled this.

@casey casey enabled auto-merge (squash) November 16, 2024 00:01
@casey
Copy link
Owner

casey commented Nov 16, 2024

Nice, great PR! If you look at the Cargo.lock changes, you can also see that this gets rid of a dependency on syn v1, since derive_where uses syn v2. So this should speed up builds a bit too, since syn is a heavy dependency.

@casey casey merged commit 5db910f into casey:master Nov 16, 2024
5 checks passed
@casey
Copy link
Owner

casey commented Nov 16, 2024

Just measured it and build time went down from ~34.5s to ~32.5 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants