-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight text within backticks when listing recipes #2423
Conversation
Seems reasonable! Needs some tests though. Should definitely test edge cases, like an unclosed backtick, etc. |
3636556
to
6abb79e
Compare
I could not wrap my head around what |
Although this type of highlighting could be nice in theory, the chosen color makes it only worse. The white backtick color stands out too much relative to...everything else in the output, to the point of making Was going to check whether changing the backtick highlight to bright blue ( |
It looks okay for me, but that's probably just my color theme. I can kinda see how it stands out too much See below. Can you post a screenshot of what it looks like for you? Cyan might be a good choice, since it goes with blue and is bright. It's the same color used for parameters, but that seems fine, and sometimes you use backticks in doc comments to call out what parameters do: |
Changed the color to cyan in #2469. Hopefully that looks good in more color schemes! |
#2272