Enhance Fish Shell Completions for Optional --justfile Argument #2148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor enhancement to the Fish shell completion script.
Changes:
JUST_JUSTFILE
environment variable when the-f
or--justfile
argument is provided in the command line.Motivation for the Change:
Currently, users specifying a custom justfile with
-f
or--justfile
do not have this reflected in their completions within the Fish shell. This can lead to inconsistencies and an unintuitive user experience. By setting theJUST_JUSTFILE
environment variable, the change is as minimal as it could be and completions will be more accurate by reflecting the correct justfile being used.Further Notes:
Testing:
just
commands in Fish shell, both with and without the-f
/--justfile
options, to ensure appropriate behavior.I hope these enhancements provide a more seamless experience for
just
users leveraging Fish shell completions.Thank you for considering this improvement!