Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --no-aliases flag to not show aliases when using --list #1961

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

WJehee
Copy link
Contributor

@WJehee WJehee commented Mar 12, 2024

Hey there, this is my first contribution to this project, please let me know if any changes need to be made.

This PR aims to fix #1891, since I came across the same problem.
I implemented the completions files, but I wasn't able to test most of them, I use zsh myself but the completions did not seem to work, although I could see them when passing --completions=zsh, perhaps you know what the problem is?

@casey
Copy link
Owner

casey commented Mar 24, 2024

Looks good to me! This just needs a test.

@WJehee
Copy link
Contributor Author

WJehee commented Mar 25, 2024

Added a test, I'm not sure if the standard is to create a new file for this but that is what I did

@casey casey enabled auto-merge (squash) March 25, 2024 17:36
@casey
Copy link
Owner

casey commented Mar 25, 2024

Looks like there's an issue with formatting.

auto-merge was automatically disabled March 25, 2024 18:03

Head branch was pushed to by a user without write access

@casey casey enabled auto-merge (squash) March 25, 2024 18:23
auto-merge was automatically disabled March 26, 2024 10:38

Head branch was pushed to by a user without write access

@casey casey merged commit d3d0dbe into casey:master Mar 26, 2024
5 checks passed
@casey
Copy link
Owner

casey commented Mar 26, 2024

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

just --list --exclude alias
2 participants