GitHub Actions: Remove actions-rs/toolchain which is end-of-life #1874
Conversation
Fixes: casey#1873 * casey#1873 Use the version of `cargo` that is pre-installed in the GHA base image.
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| profile: minimal | ||
| target: ${{ matrix.target }} |
There was a problem hiding this comment.
This line bugs me... How can we communicate the profile and target to the Rust Toolchain?
There was a problem hiding this comment.
Is rustup installed on the base image? If so, can we use rustup to install the correct toolchain?
There was a problem hiding this comment.
Yes, it is. See the last line of #1873. I know little about Rust tooling so you probably need to take over this pull request to get the release job finished.
It is cool to see that the ci job just works.
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| components: clippy, rustfmt | ||
| override: true |
There was a problem hiding this comment.
How can we communicate override to the Rust Toolchain?
There was a problem hiding this comment.
The override part? I'm not 100% sure it's being used, so we could just see if it works without it.
There was a problem hiding this comment.
The ci job is green ✅
|
Installing the right toolchain in |
Fixes: #1873
Use the version of
cargothat is pre-installed in the GHA base image.