-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Action to just test
on macOS, Ubuntu, and Windows
#1867
Conversation
just polyglot
on macOS, Ubuntu, and Windows
This is dope! I'm not sure we actually want to run it though as part of our own actions runs, since it will add another job when you make a PR, etc, which is already a little noisy with five jobs. How about moving this to a contrib directory? It's pretty common to have a directory called |
Can we please run it once (to make sure it passes) before we move it into the docs somewhere? If you merge one of the other two PRs then I |
Yup, for sure. I think it just ran and it looks like it was successful. |
OK... Should we move this code into https://github.com/casey/just/blob/master/README.md#github-actions or should we put it into a separate markdown file? Other ideas? |
I think we should move the full yaml file into |
The file that |
We can add the link from README.md in a separate PR to placate |
Okay, sorry to waffle, but looking at the workflow, I think it can be made short enough that we should just stick it in the readme, which also means we don't have to worry about a broken link. By avoiding using a matrix, we can boil it down to: name: install-just
on: [pull_request, push]
jobs:
windows:
runs-on: windows-latest
steps:
- run: choco install just
macos:
runs-on: macos-latest
steps:
- run: brew install just
ubuntu:
runs-on: ubuntu-latest
steps:
- run: sudo snap install --edge --classic just Which will be pretty easy for users to insert into their existing workflow. What do you think? |
88e847e
to
515ef13
Compare
Demonstrate how to install and use just in GitHub Actions on the three major OSes...
just polyglot
on macOS, Ubuntu, and Windowsjust test
on macOS, Ubuntu, and Windows
The working script is 3 lines longer than the matrix script and does not set fast-fail to false but it is easier to understand and most visitors will only be interested to use the Ubuntu bit. |
Nice, looks good to me! Thank you! |
Demonstrate how to install and use just in GitHub Actions on the three major operating systems without needing third-party GitHub Actions such as https://github.com/casey/just#github-actions
Developers may be interested to run the same
just
commands that they use locally on continuous integration platforms such GitHub Actions. Every time that a contributor creates a pull request,just test
could be run on the three major operating systems to provide feedback to both the contributor and reviewers that tests are passing.