Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let pages run #1464

Merged
merged 2 commits into from
Dec 31, 2022
Merged

Let pages run #1464

merged 2 commits into from
Dec 31, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 30, 2022

Organizations can be configured to not give write permissions by default.
The pages job needs permissions to write.

@casey
Copy link
Owner

casey commented Dec 30, 2022

Thanks for the PR! In what circumstance is this necessary? Is it so that actions can run on a private fork in an organization where write permissions are disabled by default?

@jsoref
Copy link
Contributor Author

jsoref commented Dec 31, 2022

Public fork in an org w/ restrictive permissions, e.g. here: https://github.com/check-spelling/casey-just/actions/runs/3797500893

@casey
Copy link
Owner

casey commented Dec 31, 2022

Makes sense, thanks for the PR!

@casey casey merged commit 01967e9 into casey:master Dec 31, 2022
@jsoref jsoref deleted the let-pages-run branch December 31, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants