Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newlines when parsing recipes #1272

Closed
wants to merge 5 commits into from

Conversation

neunenak
Copy link
Contributor

@neunenak neunenak commented Jul 22, 2022

Addresses #1266

@neunenak neunenak mentioned this pull request Sep 7, 2022
@casey
Copy link
Owner

casey commented Oct 9, 2023

Took a look at this, and I think that if this works, we should do it, even if it isn't a perfect solution. I looked at modifying the parser to switch between line-break sensitive and insensitive modes, and it seemed complicated.

@casey
Copy link
Owner

casey commented Jan 12, 2024

I updated this, and added a test, but I'm running into an issue where there's an indent before the parameter, and then no indent in the recipe body, which messes this up.

@laniakea64
Copy link
Contributor

Given that the issue this PR aimed to resolve has been fixed and closed, is this PR still needed?

Requiring the \ continuations here is better for human-readability of justfiles. And this change would be hard to support properly in vim-just (if even possible?).

What would be the rationale for this change in current just?

@casey
Copy link
Owner

casey commented Jan 12, 2024

I think it's slightly nicer to not have to add \, but I agree that it's not necessary, now that there are \ line continuations, so I'll go ahead and close this.

@casey casey closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants