Upgrade Node 16 to Node 20 #300
Conversation
Fixes gh-299 Signed-off-by: Thomas Vitale <[email protected]>
The @zeit/ncc library is no longer maintained and doesn't support Node 20. Migrating to @vercel/ncc is recommended. Fixes gh-299 Signed-off-by: Thomas Vitale <[email protected]>
Re-generate package-lock file after migrating from @zeit/ncc to @vercel/ncc Signed-off-by: Thomas Vitale <[email protected]>
Signed-off-by: Thomas Vitale <[email protected]>
|
Thanks for the PR, @ThomasVitale! I see the build is failing. I have a hunch this is unrelated and I'll check this now. I also note that for Enterprise users with self-hosted runners, Node 20 support was only added in August (https://github.com/actions/runner/releases/tag/v2.308.0) so I suspect this may be a breaking change for some. I think when we merge this the next build should be called v2. No action required in this PR, but just a reminder to myself (and an FYI to others). |
|
@ThomasVitale : Could you do me a favor to fix the build? Either merge, cherry-pick or copy and paste the changes from #301 onto your branch? This PR needs that fix to pass, but my PR also needs (some of) the dependency upgrades in your PR to pass. Between them they should do the job. |
Signed-off-by: Thomas Vitale <[email protected]>
|
@jbrunton thanks for the review. Since my branch is in a fork, I couldn't cherry-pick your commit fixing the tests, so I copied the fix. I hope that's ok. I agree about bumping the major version for the new release since it could be a breaking change. |
|
@ThomasVitale : thank you, that all looks good. I'll merge this and create a new version. |
Fixes gh-299