Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go version to latest #173

Closed
aaronshurley opened this issue Sep 23, 2021 · 3 comments
Closed

Bump go version to latest #173

aaronshurley opened this issue Sep 23, 2021 · 3 comments
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.

Comments

@aaronshurley
Copy link
Contributor

aaronshurley commented Sep 23, 2021 •
edited
Loading

Describe the problem/challenge you have
We want to ensure that the code remains compatible with the latest versions so that we do not risk falling behind and on an unsupported version (note: go supports n-1 versions).

Describe the solution you'd like
The code runs on the latest version of go.

Anything else you would like to add:

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.
@aaronshurley aaronshurley added enhancement This issue is a feature request carvel triage This issue has not yet been reviewed for validity labels Sep 23, 2021
@aaronshurley aaronshurley added carvel accepted This issue should be considered for future work and that the triage process has been completed priority/important-soon Must be staffed and worked on currently or soon. and removed carvel triage This issue has not yet been reviewed for validity labels Oct 12, 2021
@aaronshurley
Copy link
Contributor Author

Prioritizing this as important-soon so that we don't lapse in supported go versions.

@DennisDenuto
Copy link
Contributor

when bumping golang, the goreleaser version used in the release GH action will also need to be bumped.

This is because kbld generates an arm binary. and goreleaser 0.162.0 has a bug where if using go 1.17 the darwin/arm binary is skipped.

seemiller added a commit to seemiller/carvel-kbld that referenced this issue Nov 1, 2021
@seemiller
Update Golang version to 1.17 carvel-dev#173
3b6cce8 
Signed-off-by: Nicholas Seemiller <[email protected]>
seemiller added a commit to seemiller/carvel-kbld that referenced this issue Dec 9, 2021
@seemiller
Update Golang version to 1.17 carvel-dev#173
3cfc253
joaopapereira added a commit that referenced this issue Dec 14, 2021
@joaopapereira
Merge pull request #197 from seemiller/go117
9ea6e30 
Update Golang version to 1.17 #173
@joaopapereira
Copy link
Member

This issue is already done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.
Projects
Carvel
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joaopapereira @DennisDenuto @aaronshurley