Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve kctrl dev command description #1000

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Improve kctrl dev command description #1000

merged 1 commit into from
Dec 2, 2022

Conversation

ThomasVitale
Copy link
Contributor

@ThomasVitale ThomasVitale commented Dec 1, 2022 •
edited by 100mik
Loading

What this PR does / why we need it:

  • Update the description for the kctrl dev command.
  • Update the description for the -f flag.

Which issue(s) this PR fixes:

Fixes gh-964

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

@ThomasVitale
Improve kctrl dev command description
187c186 
* Update the description for the kctrl dev command.
* Update the description for the -f flag.

Fixes gh-964
@ThomasVitale ThomasVitale mentioned this pull request Dec 1, 2022
Closed
praveenrewar
praveenrewar approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

100mik
100mik approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@100mik 100mik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR

@100mik 100mik merged commit 9693c1b into carvel-dev:develop Dec 2, 2022
@vmwclabot
Copy link

@ThomasVitale, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement.

@github-actions github-actions bot added the carvel-triage This issue has not yet been reviewed for validity label Dec 5, 2022
@vmwclabot
Copy link

@ThomasVitale, we have received your signed contributor license agreement. It will be reviewed by VMware shortly. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link

@ThomasVitale, VMware has approved your signed contributor license agreement.

@100mik
Copy link
Contributor

100mik commented Dec 13, 2022

Good bot!

@ThomasVitale ThomasVitale mentioned this pull request Apr 14, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenrewar praveenrewar praveenrewar approved these changes

@100mik 100mik 100mik approved these changes

Assignees
No one assigned
Labels
carvel-triage This issue has not yet been reviewed for validity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Description for kctrl dev command in help section should also include package installs
4 participants
@ThomasVitale @vmwclabot @100mik @praveenrewar