Speed up multi-image operations #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evankanderson
had a problem deploying
to
TanzuNet Registry Dev e2e
GitHub Actions
Failure
evankanderson
had a problem deploying
to
GCR e2e
GitHub Actions
Failure
…pies. Signed-off-by: Evan Anderson <[email protected]>
evankanderson
force-pushed
the
develop
branch
from
6194c0d
to
60522f8
Compare
evankanderson
had a problem deploying
to
TanzuNet Registry Dev e2e
GitHub Actions
Failure
evankanderson
had a problem deploying
to
GCR e2e
GitHub Actions
Failure
|
The same run using the 0.35.0 imgpkg version: |
…pth. Signed-off-by: Evan Anderson <[email protected]>
evankanderson
temporarily deployed
to
TanzuNet Registry Dev e2e
GitHub Actions
Inactive
evankanderson
temporarily deployed
to
GCR e2e
GitHub Actions
Inactive
evankanderson
had a problem deploying
to
TanzuNet Registry Dev e2e
GitHub Actions
Failure
evankanderson
had a problem deploying
to
GCR e2e
GitHub Actions
Failure
…enticator cache. Signed-off-by: Evan Anderson <[email protected]>
evankanderson
temporarily deployed
to
GCR e2e
GitHub Actions
Inactive
evankanderson
temporarily deployed
to
TanzuNet Registry Dev e2e
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483
It turns out that if you pass a fresh keychain into ggcr, it will attempt to resolve the keychain each time, and doesn't keep a per-registry cache. Add a per-registry authentication cache to the per-registry transport cache.
On a "verify-only" copy of 214 images and 7.06GiB, this reduced time from about 20 minutes to about 3 minutes. Will go back and grab "before" timing in a moment.
Note: I've never touched this code before, so you may want to give this PR extra scrutiny