-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add max_decoding_message_size
config
#12
Conversation
I set the value to 104857600. (It can be confirmed in the logs.)
And the error still happens after the first input. Maybe we need to change the client side as well?
|
bd80204
to
4ef3520
Compare
@GCdePaula I tested it with examples, and it worked! |
state-client-lib/src/config.rs
Outdated
@@ -15,12 +15,17 @@ pub struct SCEnvCLIConfig { | |||
/// Default confirmations | |||
#[arg(long, env)] | |||
pub sc_default_confirmations: Option<usize>, | |||
|
|||
/// Maximum size of a decoded message | |||
#[arg(long, env, default_value_t = 4 * 1024 * 1024)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GCdePaula I thought again, and it might be better to set the default to 100 MB so we can avoid configuring these manually for the time being.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I broke the node with an input of 500Kb; with Guilherme's estimation, it is just ~$100. cartesi/rollups-contracts#77
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
fb79d84
to
8309684
Compare
@gligneul can you test with the node and check if this solves the message size issue?