Feature/remove mnomenic network difinition for localnode #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endersonmaia
requested changes
Sep 6, 2023
omidasadpour
force-pushed
the
feature/remove-mnomenic-network-difinition-for-localnode
branch
from
4f1f7a5
to
6c15cdb
Compare
endersonmaia
requested changes
Sep 12, 2023
Comment on lines
188
to
190
| {{- if eq $chainID "" }} | ||
| {{- required "A valid .Values.dapp.network is required" $network }} | ||
| {{- end }} |
There was a problem hiding this comment.
I think this if eq... is a no-op. Since there's no situation where $chainId == "".
But I don't know how a required function would work in that case, could you test?
There was a problem hiding this comment.
your right. Unfortunately, Helm's template engine doesn't have built-in support for conditionally applying required based on the value of another variable.
I think we can remove this whole section.
There was a problem hiding this comment.
I have added a required section inside the dispatcher-deployment. So if the .Values.dapp.network doesn't define and the .Values.validator.localnode.enabled doesn't enabled.
The logs before:
Error: INSTALLATION FAILED: template: rollups-node-chart/templates/dispatcher-deployment.yaml:59:122: executing "rollups-node-chart/templates/dispatcher-deployment.yaml" at <"_">: invalid value; expected string
The logs after :
Error: INSTALLATION FAILED: execution error at (rollups-node-chart/templates/dispatcher-deployment.yaml:59:87): A valid .Values.dapp.network is required
omidasadpour
force-pushed
the
feature/remove-mnomenic-network-difinition-for-localnode
branch
from
6c15cdb
to
a2efc4d
Compare
omidasadpour
force-pushed
the
feature/remove-mnomenic-network-difinition-for-localnode
branch
from
9b62c4d
to
583abbc
Compare
endersonmaia
force-pushed
the
feature/remove-mnomenic-network-difinition-for-localnode
branch
from
583abbc
to
27c30d2
Compare
endersonmaia
deleted the
feature/remove-mnomenic-network-difinition-for-localnode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
localnodeenabled Then do not need to definemnomenic&network.