Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration issues #284

Closed
SmileyChris opened this issue Apr 19, 2024 · 3 comments
Closed

Configuration issues #284

SmileyChris opened this issue Apr 19, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request prio:low Low Priority

Comments

@SmileyChris
Copy link

The readme says add [tools.pdm.bump_plugin] to pyproject.toml, but that doesn't actually work.

Firstly, because your prefix is actually tool.pdm.bump-plugin, and secondly because local pdm configuration happens in pdm.toml.

As a separate point, look at other settings in pdm config: the configuration prefixes of tool.pdm is redundant -- you could just use bump-plugin (or even just bump?).

@carstencodes carstencodes self-assigned this Apr 24, 2024
@carstencodes
Copy link
Owner

Hi,

die to PI plannings, I'm currently pretty busy.

I Hope that I will be able to have a look at it within the next days.

@carstencodes
Copy link
Owner

Hi @SmileyChris,

I'm sorry, this slept through so much.

I confess that I wrote the configuration part some time ago, when the pdm.toml contained the path to the local python interpreter and was not a good subject to be checked in. So, I decided to put it all into the pyproject.toml.

I plan to fix it in one of the coming versions.

@carstencodes carstencodes added documentation Improvements or additions to documentation enhancement New feature or request prio:low Low Priority labels May 14, 2024
@carstencodes carstencodes added this to the PDM bump 1.0 milestone May 14, 2024
@carstencodes
Copy link
Owner

Scheduled for pdm-bump 0.10.0 mid of august

carstencodes added a commit that referenced this issue Aug 21, 2024
The configuration now relies on pdm.toml
This requires pdm-pfsc in at lest 0.12.2

The configuration now uses the
plugin.bump prefix

The environment variable for VCS_PROVIDER
has also changed.

Documentation will be updated accordingly

Closes #284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request prio:low Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants