Tumblr deployer #35
Closed
Tumblr deployer #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it. There are a bunch of places where there's a blank line after the function sig, which is a little weird. But besides that it looks great! |
|
Ok, so rebasing this is not feasible at the moment, since it was based on top of a branch which is now not part of master. I tried to get through it, but it was too messy. I think instead I'm going to try to pull the relevant logic out and open a new PR, or force push over this one. Most of it is fairly contained anyway 😀 |
|
Closing in favor of #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this; re-PR'ed off
develop.