Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Ruby 3.2 in CI for 1.x #2699

Merged

Conversation

marcogregorius
Copy link

@marcogregorius marcogregorius commented Sep 7, 2023

This PR targets the 1.x-stable branch.

  • Adding Ruby 3.2 for tests in CI.
  • Use latest rmagick for Ruby 3.2 as rmagick 2.16.0 calls the deprecated rb_obj_tainted
    • Also fix the usage for the newer rmagick version to use ::Magick::Image.new(width, height) { |img| img.background_color = ...} pattern.

More context on why 1.x is still being used: #2640 (comment).

Would also appreciate if the maintainer could release a new gem for 1.x 🙏

@marcogregorius marcogregorius marked this pull request as draft September 9, 2023 00:02
@marcogregorius marcogregorius marked this pull request as ready for review September 13, 2023 03:47
@marcogregorius marcogregorius changed the title Test against Ruby 3.2 in CI Test against Ruby 3.2 in CI for 1.x Sep 13, 2023
@mshibuya mshibuya merged commit 45ad4c1 into carrierwaveuploader:1.x-stable Sep 24, 2023
34 checks passed
@mshibuya
Copy link
Member

Thanks, just released 1.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants