Chore: bump mongoid 9 and support ruby 3.3 #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mini_magick > 4 fails with carrierwave with calls to imagemagick `run_command`
- this was producing a warning about using node 12 which deprecated https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Hello @eqladios, @rmm5t, my team is eagerly waiting for this release and I wondered if you have seen the recent update from grid_fs to support v9? Thank you for getting this PR ready early on 💖 |
Thank you @zoltanlantos, grid_fs has already released 2.6 which supports mongoid 9 so this is no longer a draft Taking another look on the PR from my side and hopefully it can be reviewed by @rmm5t and maintainers soon |
Passed the test by ensuring that the embedded `mongo_location` document is saved first before saving and checking the parent document.
rmm5t
approved these changes
Nov 22, 2024
| @@ -6,12 +6,13 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| mongodb: [4.4] | |||
| ruby: [2.7, "3.0", 3.1, 3.2] | |||
| ruby: [2.7, "3.0", 3.1, 3.2, 3.3] | |||
|
Thanks v1.5.0 released: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is draft, dependent on mongoid-grid_fs supporting mongoid 9This include a couple of updates, hopefully it's relevant:
run_commandso I constrained it in the dev environment to < v5catcommand in the ci workflow to use the ruby version used in matrix as the cat command was failing to run on failures. Probably need to check hardcodedmimemagic-0.4.3tooactions/checkoutto v4 as v2 was logging errors about deprecated node 12Fixes #213