Sr/make gridfs optional #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriedel
commented
Nov 28, 2022
| @@ -1,5 +1,5 @@ | |||
| module Carrierwave | |||
| module Mongoid | |||
| VERSION = "1.3.0" | |||
| VERSION = "2.0.0" | |||
There was a problem hiding this comment.
Not sure how you guys would want to handle a version update, as part of this PR or separately. Also not sure about the target version number. As I understand semver, a major version bump would be in order due to the backwards incompatible change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
mongoid-grid_fsgem is lagging a bit in allowing for mongoid 8, and we don't use the GridFS storage, this PR proposes to make the GridFS dependency optional. This had already been requested a few years back in #119 - maybe the sentiment regarding the dependency on GridFS has changed.In order to make testing with and without GridFS as easier, the inclusion of mongoid-grid_fs can be controlled with an environment variable, both during
bundle installand when running the specs.