-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't store _old_ if we're passed nil #175
base: master
Are you sure you want to change the base?
Don't store _old_ if we're passed nil #175
Conversation
Sorry for the awful delay here. Thanks to #179, and after a hiatus, I'm now in the process of catching up with things on this project. If this issue is still a problem, could you please rebase on master to get the test suite green for this PR? |
2070faa
to
84b8e16
Compare
@rmm5t No worries! I rebased off master, but I'm not sure if this change is still necessary. Will try to play around some more to see. |
Hello there. We're facing this exact issue so I think this change is still necessary 🙂 |
That being said, testing this PR in a custom fork it seems that it should be |
@artfuldodger @simonc Sorry for the long delay with this PR. Would someone be willing to investigate this further while also adding a spec to confirm behavior? |
I'm not using Mongo any more, so I'm of no use here |
Saying, for example
user.update(avatar: nil)
will result with theavatar_filename
set to "old", which is unexpected.