-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning/depency to carrierwave and updating translations for carrierwave 3 (#3 and #25) #27
Versioning/depency to carrierwave and updating translations for carrierwave 3 (#3 and #25) #27
Conversation
How wonderful, thank you so much for working on such a heavy lifting! |
…s version to 3.0.0 as well See issue #3 and rails-18n (https://github.com/svenfuchs/rails-i18n#gem-installation) as example
Thx @mshibuya Co-authored-by: Mitsuhiro Shibuya <[email protected]>
Co-authored-by: Mitsuhiro Shibuya <[email protected]>
ko.yml was added with PR #21 but was not merged yet
Thank you, too :) Regarding the merge conflict in
Did I got this right? Otherwise feel free to correct this :) |
I think you need at least Ruby 2.5 for the automated test with Ruby 2:
|
Carrierwave 3 depends on Ruby >= 2.5.0
That's correct! I think it's good to go now. |
@araccaine Just released 3.0.0 🚀 |
Nice 🥳
Yes I would be glad to do so :) |
Great! The invitation is on the way 👍 |
Summary
This PR addresses #3 and #25 as they are both strongly related.
Please feel free to comment, revise and update this PR.
What
Tests
Two tests failed when running
$ rspec
because the capitalization was wrong: translation instead of Translation. I updated these characters.Versioning
carrierwave
version 3 as runtime dependency and use3.0.0
as new version for this gem as proposed in Versioning #3Translations and keys
See #25
_whitelist_
to_allowlist_
_blacklist_
to_denylist_
_processing_error
keys into a generic one and updated the translations if possible%{e}
...)ja
and Thaith
were not updated because I couldn't update and verify these strings for correctnessde
) by myselfzh-TW
andzh-CN
) and for enhancing the existing onesFurther comments
One may also create a new branch like
carrierwave-2-x
from the currentcarrierwave-i18n
version0.2.0
and update thegemspec
file there as well for consistency? Maybe also updating the version number to2.2.0
to be consistent?Maybe also the pipeline for publishing on rubygems.org needs an update to allow independent managing of this gem?
E.g. the updated chinese translations may also go to version 0.2.0 e.g. as new "carrierwave 2 dependent version" 0.2.1.