-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sidebar sticky #140
base: main
Are you sure you want to change the base?
Make sidebar sticky #140
Conversation
Thank you for this contribution @milanmlft! I'll take a look at it with @froggleston at one of our upcoming co-working meetings. |
Hi @ErinBecker! Hope you're doing well. I know you guys are super busy, but did you have a chance to look at this yet? Thanks! |
Hi @milanmlft - Happy New Year! 🥳 I'm back at my desk with renewed percent effort to dedicate to Workbench and am finally reviewing your contribution. Thank you so much for your patience. I've locally tested this PR and can confirm that the sidebar is indeed sticky! I personally agree that this is a great improvement to the lesson formatting and makes navigation much easier. After reading through some of the conversation on #16 and further issues referenced there, I want to do my due diligence and make sure this solution is compatible with some of the concerns raised there:
Apologies for the inconclusive response after such a long delay. I'm back in the saddle and ready to start making progress towards implementing this improvement and will be following the conversation related to my questions above closely. @froggleston - please feel free to chime in. |
FWIW, I don't think there are any new JS libraries in here, so that concern is taken care of. |
Hi @milanmlft - apologies for the delay in replying! Thank you for the PR - I think a sticky sidebar would be a good inclusion into the workbench, but have a couple of issues. With longer content in the sidebar, the The JS solution also has some issues (as is often the case of course), so isn't perfect, but does scroll more efficiently with the page, unlike the |
Keeps the sidebar navigation menu visible when scrolling past it.
I mainly implemented this as a request for https://github.com/learntodiscover/varnish but thought I'd contribute it here as well. Happy to address any feedback!
Fixes #16