Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local linking issues #262

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Fix local linking issues #262

merged 3 commits into from
Feb 28, 2022

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Feb 28, 2022

This fixes a few issues with local links in some situations:

  1. links originating from a page in the root of the repository now are treated
    the same way as links from within a folder in the repository (e.g.
    a link that is [first episode](episodes/introduction.md) will now properly
    link to the episode in the rendered HTML.
  2. links to the setup page will now properly render to the correct place (index)
  3. The setup will contain a section (eventually to be replaced by a
    callout with nav elements).

This also addresses #250 where the BASH was interpreting 08 as octal and freaking out.

This will fix #260 and #250

@zkamvar zkamvar enabled auto-merge February 28, 2022 19:33
@zkamvar zkamvar merged commit 2d507e5 into main Feb 28, 2022
auto-merge was automatically disabled February 28, 2022 19:39

Pull request was closed

@zkamvar zkamvar deleted the fix-setup-link branch February 28, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to setup page are broken
1 participant