-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not rewrite special links such as mailto: (and similar non-path links) #538
Labels
bug
Something isn't working
Comments
yikes! Mea culpa. I'll add a catch for that. |
I've opened a patch in #539 and have tested it locally. I will do a patch release once I confirm that the remote integration test works |
The remote test appears to be working as shown in this HTML preview |
I have released this to the R-universe and should be available globally within the hour |
Thanks for the quick fix 🙂 |
milanmlft
pushed a commit
to LearnToDiscover/sandpaper
that referenced
this issue
Nov 13, 2023
* accept doi field in lesson config * do not transform mailto links This will fix carpentries#538 * bump version to 0.14.1; add news * allow for empty or missing DOI; bump news --------- Co-authored-by: Toby Hodges <[email protected]> Co-authored-by: Zhian N. Kamvar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using a clickable E-Mail link, such as
mailto:[email protected]
, it is being prefixed by the base URL and thereby breaking it, resulting infile:///local/home/a.pirogov/projects/ias9/scientific-metadata/site/docs/mailto:[email protected]
(locally)https://carpentries-incubator.github.io/scientific-metadata/mailto:[email protected]
(online)Apparently it is interpreted as a "local path".
The text was updated successfully, but these errors were encountered: