Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rewrite special links such as mailto: (and similar non-path links) #538

Closed
apirogov opened this issue Nov 9, 2023 · 5 comments · Fixed by #539
Closed

Do not rewrite special links such as mailto: (and similar non-path links) #538

apirogov opened this issue Nov 9, 2023 · 5 comments · Fixed by #539
Labels
bug Something isn't working

Comments

@apirogov
Copy link

apirogov commented Nov 9, 2023

When using a clickable E-Mail link, such as mailto:[email protected], it is being prefixed by the base URL and thereby breaking it, resulting in

Apparently it is interpreted as a "local path".

@zkamvar
Copy link
Contributor

zkamvar commented Nov 9, 2023

yikes! Mea culpa. I'll add a catch for that.

@zkamvar zkamvar added the bug Something isn't working label Nov 9, 2023
zkamvar added a commit that referenced this issue Nov 9, 2023
@zkamvar
Copy link
Contributor

zkamvar commented Nov 9, 2023

I've opened a patch in #539 and have tested it locally. I will do a patch release once I confirm that the remote integration test works

@zkamvar
Copy link
Contributor

zkamvar commented Nov 9, 2023

@zkamvar
Copy link
Contributor

zkamvar commented Nov 9, 2023

I have released this to the R-universe and should be available globally within the hour

@apirogov
Copy link
Author

Thanks for the quick fix 🙂

milanmlft pushed a commit to LearnToDiscover/sandpaper that referenced this issue Nov 13, 2023
* accept doi field in lesson config

* do not transform mailto links

This will fix carpentries#538

* bump version to 0.14.1; add news

* allow for empty or missing DOI; bump news

---------

Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: Zhian N. Kamvar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants