Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librarycarpentry/lc-data-intro #60

Closed
4 tasks done
zkamvar opened this issue Apr 10, 2023 · 2 comments
Closed
4 tasks done

librarycarpentry/lc-data-intro #60

zkamvar opened this issue Apr 10, 2023 · 2 comments
Labels
03 May lesson A Carpentries Lesson To Transition status: ready This label is for lessons that are ready for transition to the workbench

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Apr 10, 2023

tracking issue for https://github.com/librarycarpentry/lc-data-intro

preview: https://fishtree-attempt.github.io/lc-data-intro

There is a problem with {pegboard} attempting to detect math in the lesson. There are stray $ that are not protected. The solution is to encode them as code elements.

✔ Converting 'librarycarpentry/lc-data-intro/_episodes/01-regular-expressions.md' to sandpaper ... done

! Some math could not be parsed... likely because of shell variable examples
ℹ Below is the error
! Inline math delimiters are not balanced.

HINT: If you are writing BASIC code, make sure you wrap variable
      names and code in backtics like so: `INKEY$`.

Below are the pairs that were found:
start...end
-----...---
     ...rgani.e\w+$
     ...rgani.e\w?$
@zkamvar zkamvar added run pending Lessons that have not yet been tested locally status: in progress This label is for lessons that are currently being processed, but still have issues and removed run pending Lessons that have not yet been tested locally labels Apr 10, 2023
@zkamvar zkamvar added the lesson A Carpentries Lesson To Transition label Apr 11, 2023
@zkamvar zkamvar added the 03 May label Apr 28, 2023
zkamvar added a commit that referenced this issue May 2, 2023
zkamvar added a commit to carpentries/sandpaper that referenced this issue May 2, 2023
This came up in
carpentries/lesson-transition#60 where they
use a markdown file as data for regex. When I made the links local,
these were being converted to HTML. This will fix that situation.
@zkamvar zkamvar added status: ready This label is for lessons that are ready for transition to the workbench and removed status: in progress This label is for lessons that are currently being processed, but still have issues labels May 2, 2023
@zkamvar
Copy link
Contributor Author

zkamvar commented May 3, 2023

fixed in 0cf24ae

Note: this had issues with the transition and it was likely because there were many stale branches.

@zkamvar zkamvar closed this as completed May 3, 2023
@zkamvar
Copy link
Contributor Author

zkamvar commented May 3, 2023

This release encountered issues similar to that of https://github.com/carpentries/lesson-transition/releases/tag/release_dc%2Fimage-processing

Error Message

There was an error when pushing to the remote. The good news is that it was a pre-push error, which meant that the main branch was not yet pushed and thus the workflows were not running.

This was a similar error to a359d3e

Recovery

I applied the procedure similar to #46 (comment)

  1. opened the functions.R file and scrolled to the definition for
    setup_github()
  2. start R and run source("functions.R")
  3. provision the five parameters
    • path <- "release/librarycarpentry/lc-data-intro"
    • owner <- "librarycarpentry"
    • repo <- "lc-sql"
    • action <- "close-pr.yaml"
    • .token <- askpass::askpass() and paste the release token
  4. run lines 468 through 480
  5. run default <- "gh-pages" (because by then the default had changed)
  6. run line 489 (oops)
  7. run lines 516 through 552 (force push and protect main branch)
  8. run lines 555 through 576
  9. run lines 516 through 552

This WAS a successful run, but it did require manual intervention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 May lesson A Carpentries Lesson To Transition status: ready This label is for lessons that are ready for transition to the workbench
Projects
None yet
Development

No branches or pull requests

1 participant