-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 404 page #259
base: main
Are you sure you want to change the base?
Add 404 page #259
Conversation
✅ Deploy Preview for carpentries-beta-handbook-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ah this breaks horrifically due to sphinx not actually supporting custom 404 pages out of the box: https://sphinx-notfound-page.readthedocs.io/en/latest/ I'll adapt this PR to use the extension above instead. |
Still not working with the extension as it automatically injects prefixes to URLs e.g. |
@froggleston It is set up on our current sphinx site. I'm just not sure how. See https://docs.carpentries.org/xyz |
@maneesha The previous site uses a much older version of the extension that supports no prefix. However, unhelpfully, the extension devs removed this in later versions instead opting for "/" or a full prefix. There is no longer an option for no prefix. I can try the old version and see how it works. |
Strangely this seems to work now with the original extension. |
Fixes #221