Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for pt-BR subtitles #38

Closed
pguizeline opened this issue Oct 11, 2017 · 7 comments
Closed

Search for pt-BR subtitles #38

pguizeline opened this issue Oct 11, 2017 · 7 comments
Assignees

Comments

@pguizeline
Copy link

pguizeline commented Oct 11, 2017

Hi!

What option should I use when searching for brazilian portugue subtitles? I've tried:
-l pt-BR, pob, pb

The result is:
An error occured processing the language list

If I use "pt" I end up fetching portugues subs.

Thanks!

@caronc
Copy link
Owner

caronc commented Oct 11, 2017

Hmm... pt-br looks good; I'll have a look at the code and see what i can find out. If you visit sites like addic7ed, do you see subtitles in the language you want?

If so, can you pass back a hyper-link here to some Portuguese(Brazilian) examples? It would really help with the debugging process.

@caronc caronc self-assigned this Oct 11, 2017
@pguizeline
Copy link
Author

I get the error using pt-br all lowercase too. Addic7ed has pt-br subtitles, what kind of examples do you mean?

@caronc
Copy link
Owner

caronc commented Oct 11, 2017

I was having difficulties finding examples on Addic7ed's website (but i just found one now so I'll use that as an example). Anyway, just like your last issues: I'll try and have you something for you to try before the start of next week.

Thanks for reporting this issue!

@pguizeline
Copy link
Author

I should be the one thanking you!! Thanks a lot for all your fast replies and don't rush! I wish I could help you more!

@caronc
Copy link
Owner

caronc commented Oct 13, 2017

I just added a small change that will kind of help you out. The way the languages are set up in the Subliminal don't really take in account for content after the hyphen.

I added the language codes 'pb', pob, and Brazilan. pb isn't really the correct code (pt-br is) so i don't know how many matches it will hit. pb IS however the Brazilian language code used on OpenSubtitles; so it's possible other sites use this. I know for sure Addic7ed just uses pt-br (so you'll only hit when using pt here).

# The following will guarantee at least a match against pb or pt if present
./Subliminal.py -l pb,pt

It's unfortunate, it's like the world cursed Brazilians by not giving you guys your own language code and providing it as just a subset of the Portuguese one. 😞

@pguizeline
Copy link
Author

This is awesome!!! It's working perfectly! Thanks a lot for all your time and effort! Do you have any account that I can donate for all your work?

@caronc
Copy link
Owner

caronc commented Oct 13, 2017

I'm glad everything is back up and going for you! You honestly don't owe me anything at all, although it's super kind of you to offer though!

Please feel free to let me know if you have any more problems. 😄

@caronc caronc closed this as completed Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants