-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output Control Support #29
Conversation
…g states correctly)
Sorry to take so long to merge this; just looking at it now. For those who don't have outputs (like me for example, i have a very old UltraSync panel); merging this code shouldn't break? Is the |
I think I've written it in a way where it shouldn't conflict with users who don't have an My branch works for me and I've been using it flawlessly over the past few weeks. I just don't want other users to have issues. |
I reviewed it; i don't see the harm in the PR. Merging it now and closing. Thanks for this! |
On a side note; it might be cool if you could do another PR on the side and update the |
I've completed the output control changes so that it is now supported in the
ha-ultrasync
integration.Changes made:
switch
service that executes theset_output_control
functionBefore you merge it, I just need double checking that integration works for users who do not have an output control in there alarm.
Also, the states of the output correctly initialise to 0 as they should when the integration is loaded but when the output is switched on, the sensor doesn't change state from 0 to 1. I think my code for the
coordinator.py
is not 100% correct. If you could take a look that would be great.I haven't found any use case where the state of the output would need to be tracked as the main functionality of opening and closing the output through the switch is what i wanted to get working in home assistant. But having the output sensor state update as it should would be nice.