Skip to content

Run synchronous code asynchronously #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caronc merged 6 commits into from
Sep 30, 2020
Merged

Run synchronous code asynchronously #304

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8aa2bad
use run_in_executor to run sync method in async method
raman325 Sep 18, 2020
1548ade
add ThreadPoolExecutor
raman325 Sep 18, 2020
1a94ee9
use keyword argument
raman325 Sep 18, 2020
e6b53ed
fix line length
raman325 Sep 30, 2020
240a118
use default max_workers
raman325 Sep 30, 2020
32f9c5e
use context manager to ensure threads are cleaned up properly
raman325 Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion apprise/py3compat/asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@

import sys
import asyncio
from concurrent.futures import ThreadPoolExecutor
from functools import partial
from ..URLBase import URLBase
from ..logger import logger

Expand Down Expand Up @@ -101,7 +103,12 @@ async def async_notify(self, *args, **kwargs): # noqa: E999
Async Notification Wrapper
"""
try:
return self.notify(*args, **kwargs)
loop = asyncio.get_event_loop()
with ThreadPoolExecutor() as executor:
return await loop.run_in_executor(
executor,
partial(self.notify, *args, **kwargs),
)

except TypeError:
# These our our internally thrown notifications
Expand Down