Optimize empty case in Vec::retain

carolynzech · Jul 29, 2024 · 5d51099 · 5d51099
1 parent a152820
commit 5d51099
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/alloc/src/vec/mod.rs b/alloc/src/vec/mod.rs
@@ -1711,6 +1711,12 @@ impl<T, A: Allocator> Vec<T, A> {
         F: FnMut(&mut T) -> bool,
     {
         let original_len = self.len();
+
+        if original_len == 0 {
+            // Empty case: explicit return allows better optimization, vs letting compiler infer it
+            return;
+        }
+
         // Avoid double drop if the drop guard is not executed,
         // since we may make some holes during the process.
         unsafe { self.set_len(0) };