Skip to content

Commit

Permalink
Add scope attributes to tracer and meter creation (open-telemetry#2760)
Browse files Browse the repository at this point in the history
  • Loading branch information
jack-berg authored Aug 30, 2022
1 parent 8012afe commit d453688
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
11 changes: 6 additions & 5 deletions specification/metrics/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,12 @@ suggestions regarding how to implement this efficiently.

### Meter Creation

New `Meter` instances are always created through a `MeterProvider` (see
[API](./api.md#meterprovider)). The `name`, `version` (optional), and
`schema_url` (optional) arguments supplied to the `MeterProvider` MUST be used
to create an [`InstrumentationScope`](../glossary.md#instrumentation-scope)
instance which is stored on the created `Meter`.
New `Meter` instances are always created through a `MeterProvider`
(see [API](./api.md#meterprovider)). The `name`, `version` (optional),
`schema_url` (optional), and `attributes` (optional) arguments supplied to
the `MeterProvider` MUST be used to create
an [`InstrumentationScope`](../glossary.md#instrumentation-scope) instance which
is stored on the created `Meter`.

Configuration (i.e., [MetricExporters](#metricexporter),
[MetricReaders](#metricreader) and [Views](#view)) MUST be managed solely by the
Expand Down
11 changes: 6 additions & 5 deletions specification/trace/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,12 @@

### Tracer Creation

New `Tracer` instances are always created through a `TracerProvider` (see
[API](api.md#tracerprovider)). The `name` and `version` arguments supplied to
the `TracerProvider` must be used to create an
[`InstrumentationScope`](../glossary.md#instrumentation-scope) instance which is
stored on the created `Tracer`.
New `Tracer` instances are always created through a `TracerProvider`
(see[API](api.md#tracerprovider)). The `name`, `version` (optional),
`schema_url` (optional), and `attributes` (optional) arguments supplied to
the `TracerProvider` must be used to create
an [`InstrumentationScope`](../glossary.md#instrumentation-scope) instance which
is stored on the created `Tracer`.

Configuration (i.e., [SpanProcessors](#span-processor), [IdGenerator](#id-generators),
[SpanLimits](#span-limits) and [`Sampler`](#sampling)) MUST be managed solely by
Expand Down

0 comments on commit d453688

Please sign in to comment.