-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizations plus bug fix #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
which makes `opts::resolve_inner` easier to understand, reduce number of parameters required for `download_extract_and_verify` and `collect_bin_files` and reducing size of future returned by `opts::resolve_inner` by dropping `cargo_toml::{Manifest, Package}` as early as possible since they are very large: `Manifest` is 3000 Bytes large while `Package` is 600 Bytes large. Signed-off-by: Jiahao XU <[email protected]>
since they are usually small enough to fit in inlined version of `CompactString`. Signed-off-by: Jiahao XU <[email protected]>
in `RepositoryHost::get_default_pkg_url_template`. Signed-off-by: Jiahao XU <[email protected]>
…paths` Signed-off-by: Jiahao XU <[email protected]>
by calling `fetcher.target_meta()` to obtain final metadata after downloaded and extracted the binaries. Signed-off-by: Jiahao XU <[email protected]>
in `download_extract_and_verify`: Replace `Itertools::join` with `Itertools::format` to avoid allocating the string. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
since we only need `product.name` Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
so that we don't need to `unwrap()` on `Product::name`. Signed-off-by: Jiahao XU <[email protected]>
passcod
requested changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
passcod
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download::and_extract
: Avoid dup monomorphization4096 * 5
opts::resolve
: Avoid unnecessaryclone
sopts::resolve
: Do not over-reserveopts::Options::resolver
=>resolvers
resolve::PackageInfo
opts::resolve_inner
easier to understanddownload_extract_and_verify
andcollect_bin_files
opts::resolve_inner
by droppingcargo_toml::{Manifest, Package}
as early as possible sinceManifest
is 3000 Bytes large whilePackage
is 600 Bytes large.fetchers::Data
: UseCompactString
for field name & versionsince they are usually small enough to fit in inlined version of
CompactString
.gh_crate_meta
: Avoid unnecessary allocationin
RepositoryHost::get_default_pkg_url_template
.Itertools::cartesian_product
inapply_filenames_to_paths
ops::resolve
: Avoid unnecessaryclone
& reduce future sizeby calling
fetcher.target_meta()
to obtain final metadata afterdownloaded and extracted the binaries.
ops::resolve
: Avoid unnecessary allocationin
download_extract_and_verify
: ReplaceItertools::join
withItertools::format
to avoid allocating the string.BinFile::from_product
: Takes&str
instead of&Product
since we only need
product.name
BinFile::from_product
=>BinFile::new
ops::resolve::Bin
so that we don't need to
unwrap()
onProduct::name
and reduce memory usage.
Signed-off-by: Jiahao XU [email protected]