Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of log with tracing #527

Merged
merged 10 commits into from
Nov 13, 2022
Merged

Replace use of log with tracing #527

merged 10 commits into from
Nov 13, 2022

Conversation

NobodyXu
Copy link
Member

@NobodyXu NobodyXu commented Nov 11, 2022

Resolved #522

  • Add dep tracing v0.1.37 to binstalk

  • Use tracing instead of log for logging in binstalk

  • Rm dev dep env_logger since log is no longer used

  • Rm unused dep log from binstalk

  • Replace use of log with tracing in crates/bin

  • Enable feat std of dep log in crates/bin

  • Add dep tracing v0.1.37 to binstalk-downloader

  • Replace use of log with tracing in binstalk-downloader

  • Rm unused dep log from binstalk-downlaoder

  • Wrap ops::{install, resolve} in tracing::instrument

  • Wrap Download::and_{extract, visit_tar} in instrument

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Unverified

This user has not yet uploaded their public signing key.
to create a span automatically upon entering the future.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu marked this pull request as ready for review November 11, 2022 07:25
@NobodyXu NobodyXu enabled auto-merge (squash) November 11, 2022 07:26
@NobodyXu NobodyXu requested a review from passcod November 11, 2022 07:27
@NobodyXu NobodyXu merged commit 4e87587 into main Nov 13, 2022
@NobodyXu NobodyXu deleted the tracing branch November 13, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace log with tracing
2 participants