Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable feature thin of dep zstd for any target built natively #480

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

NobodyXu
Copy link
Member

@NobodyXu NobodyXu commented Oct 12, 2022

  • Add new feature binstalk-downloader/zstd-thin
  • Add new feature binstalk/zstd-thin
  • Add new feature binstalk/zstd-thin
  • Enable feature zstd-thin for targets built natively

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

@NobodyXu NobodyXu marked this pull request as ready for review October 12, 2022 05:39
@NobodyXu NobodyXu enabled auto-merge (squash) October 12, 2022 05:39
@NobodyXu NobodyXu requested a review from passcod October 12, 2022 05:39
@passcod
Copy link
Member

passcod commented Oct 12, 2022

May need an opt-out for some targets: gyscos/zstd-rs#167

@NobodyXu
Copy link
Member Author

May need an opt-out for some targets: gyscos/zstd-rs#167

I suspect this might be related to cross, the issue linked seems not to be related as it is for windows.
P.S. you can simply write https://github.com/gyscos/zstd-rs/pull/167, github would automatically format it to gyscos/zstd-rs#167.

@passcod
Copy link
Member

passcod commented Oct 13, 2022

I did ^^
image

@NobodyXu
Copy link
Member Author

I did ^^

I see, when I copied/picked reply on github, it is formatted as a link.

@NobodyXu NobodyXu marked this pull request as draft November 10, 2022 01:25
auto-merge was automatically disabled November 10, 2022 01:25

Pull request was converted to draft

@NobodyXu
Copy link
Member Author

May need an opt-out for some targets: gyscos/zstd-rs#167

I've opt-out zstd/thin for any target built by cross.

@NobodyXu NobodyXu marked this pull request as ready for review November 22, 2022 06:33
@NobodyXu NobodyXu enabled auto-merge (squash) November 22, 2022 06:35
@NobodyXu NobodyXu disabled auto-merge November 22, 2022 06:35
@NobodyXu NobodyXu changed the title Enable feature thin of dep zstd Enable feature thin of dep zstd for any target built natively Nov 22, 2022
@NobodyXu NobodyXu enabled auto-merge (squash) November 22, 2022 06:35
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu merged commit bd3f1d5 into main Nov 22, 2022
@NobodyXu NobodyXu deleted the optimize-zstd branch November 22, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants