Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support specifing versions via crate_name@req #210

Merged
merged 6 commits into from
Jul 12, 2022
Merged

Feature: Support specifing versions via crate_name@req #210

merged 6 commits into from
Jul 12, 2022
+79 −41

Conversation

NobodyXu
Copy link
Member

Prepare for #175

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

NobodyXu added 4 commits July 12, 2022 16:47
@NobodyXu
Impl new type helpes::CrateName
38c8bc8 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Add new variant BinstallError::DuplicateVersionReq
41961ce 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Support specifing ver via crate_name@version
ff0bd4d 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Add diagnostic(help) to DuplicateVersionReq
e2207f7 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu added the PR: feature work PR that provides or works on a new feature label Jul 12, 2022
@NobodyXu NobodyXu marked this pull request as ready for review July 12, 2022 08:09
@NobodyXu NobodyXu requested a review from passcod July 12, 2022 08:09
passcod
passcod reviewed Jul 12, 2022
View reviewed changes
@passcod passcod changed the title Feature: Support specifing feature via crate_name:req Feature: Support specifing versions via crate_name@req Jul 12, 2022
NobodyXu added 2 commits July 12, 2022 18:33
@NobodyXu
Treat 1.2.3 as =1.2.3 to match cargo-install
c879412 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Rm unused BinstallError::VersionWarning
aecc474 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu merged commit a672f00 into cargo-bins:main Jul 12, 2022
@NobodyXu NobodyXu deleted the feature/crate-version branch July 12, 2022 09:09
@passcod
Copy link
Member

passcod commented Jul 12, 2022

Also when merging PRs (this one's done, but for reference) I like to add a short note to the draft release; the current one is https://github.com/ryankurte/cargo-binstall/releases/tag/untagged-0cff6ae583663c58c4de — that way it's a lot easier when it comes to writing up the release notes.

@NobodyXu
Copy link
Member Author

Also when merging PRs (this one's done, but for reference) I like to add a short note to the draft release; the current one is https://github.com/ryankurte/cargo-binstall/releases/tag/untagged-0cff6ae583663c58c4de — that way it's a lot easier when it comes to writing up the release notes.

Got it.

@passcod passcod mentioned this pull request Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passcod passcod

Assignees
No one assigned
Labels
PR: feature work PR that provides or works on a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NobodyXu @passcod