feature: Install binaries atomically #195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a new function
helpers::atomic_install
and used it inbins::BinFile::install_bin
.helpers::atomic_install
first attempts to userename
to atomically install the file.When
rename
fails, it will switch to the fallback, which usestempfile::NamedTempFile
to create a named temporary file at the parent ofdst
,std::io::copy
thesrc
into the tempfile, then persist the named tempfile todst
atomically.It also added a new function
helpers::atomic_symlink_file
and used it inbins::BinFile::install_link
.It creates a
tempfile::TempPath
, create a symlink with theTempPath
as the linkname, then persist it tolink
.Signed-off-by: Jiahao XU [email protected]