Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cargo-toml-workspace: Rm dep on binstalk-types #1386

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Refactor cargo-toml-workspace: Rm dep on binstalk-types #1386

merged 1 commit into from
Sep 25, 2023

Conversation

NobodyXu
Copy link
Member

cargo-toml-workspace should not depend on and be coupled with binstalk-types but instead be a generic crate that can be used outside cargo-binstall.

@NobodyXu NobodyXu requested a review from passcod September 25, 2023 05:12
@NobodyXu NobodyXu enabled auto-merge September 25, 2023 05:17
@NobodyXu NobodyXu added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 1fe4702 Sep 25, 2023
@NobodyXu NobodyXu deleted the cargo-toml-workspace-decouple branch September 25, 2023 06:08
This was referenced Sep 25, 2023
Merged
Merged
Closed
Merged
@NobodyXu NobodyXu mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passcod passcod passcod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NobodyXu @passcod