Initial signing support #1345

passcod · 2023-09-04T15:38:12Z

Ref #1

passcod · 2023-09-04T18:48:41Z

I'm not entirely sure why the test isn't working (ie why the PkgMeta isn't finding the signing section), @NobodyXu mind taking a look? Otherwise I think pretty much all the code is done.

crates/bin/src/args.rs

crates/binstalk-fetchers/src/gh_crate_meta.rs

Co-authored-by: Jiahao XU <[email protected]>

crates/bin/src/args.rs

crates/binstalk-fetchers/src/gh_crate_meta.rs

crates/binstalk-fetchers/src/signing.rs

crates/binstalk-fetchers/src/quickinstall.rs

e2e-tests/signing.sh

crates/binstalk/src/ops/resolve.rs

Co-authored-by: Jiahao XU <[email protected]>

crates/binstalk-fetchers/src/gh_crate_meta.rs

crates/binstalk/src/ops/resolve.rs

e2e-tests/signing.sh

Co-authored-by: Jiahao XU <[email protected]>

NobodyXu · 2023-09-23T00:25:01Z

ok so the macos CI failed due to connection error to the http server.
I would probably push directly to this branch later to solve the issue.

Move the tls cert creation into `signing.sh` and sleep for 10s to wait for https server to start. Signed-off-by: Jiahao XU <[email protected]>

- Use a tempdir generated by `mktemp` for all certificates-related files - Put other checked-in files into `e2e-tests/signing` Signed-off-by: Jiahao XU <[email protected]>

Wait for server to start up by trying to connect to it. Signed-off-by: Jiahao XU <[email protected]>

Use single quote instead of double quote to avoid automatic expansion from bash Signed-off-by: Jiahao XU <[email protected]>

Remove `timeout` since it is not supported on MacOS. Signed-off-by: Jiahao XU <[email protected]>

Signed-off-by: Jiahao XU <[email protected]>

By using double `//` for the value passed to option `-subj` Signed-off-by: Jiahao XU <[email protected]>

Pass `--ssl-revoke-best-effort` to prevent schannel from checking ssl revocation status. Signed-off-by: Jiahao XU <[email protected]>

Signed-off-by: Jiahao XU <[email protected]>

so that we can see the error message there. Signed-off-by: Jiahao XU <[email protected]>

use `python3` since macos-latest still has python2 installed and `python` is a symlink to `python2` there. Signed-off-by: Jiahao XU <[email protected]>

passcod · 2023-09-23T06:18:40Z

Thanks for finishing this :)

passcod added 10 commits September 4, 2023 12:33

Add CLI options

05bf619

Add manifest types

d5ef17f

Thread signature policy through to fetchers

2aba65e

Thread signing section through from metadata

a709fb5

Implement signing validation

6c6bfec

Clippy

e308fb3

Attempt testing

7104a86

Yes and

c7dcfcc

Why

dea2d04

fmt

45cdf68

NobodyXu requested changes Sep 5, 2023

View reviewed changes

crates/bin/src/args.rs Outdated Show resolved Hide resolved

crates/binstalk-fetchers/src/gh_crate_meta.rs Outdated Show resolved Hide resolved

passcod and others added 2 commits September 5, 2023 13:45

Update crates/bin/src/args.rs

f9acd1d

Co-authored-by: Jiahao XU <[email protected]>

Update crates/binstalk-fetchers/src/gh_crate_meta.rs

de3f295

Co-authored-by: Jiahao XU <[email protected]>

NobodyXu requested changes Sep 5, 2023

View reviewed changes

crates/bin/src/args.rs Outdated Show resolved Hide resolved

NobodyXu requested changes Sep 5, 2023

View reviewed changes

crates/binstalk-fetchers/src/quickinstall.rs Show resolved Hide resolved

e2e-tests/signing.sh Outdated Show resolved Hide resolved

NobodyXu requested changes Sep 5, 2023

View reviewed changes

crates/binstalk/src/ops/resolve.rs Outdated Show resolved Hide resolved

passcod and others added 8 commits September 5, 2023 15:58

Update crates/bin/src/args.rs

98ed25b

Co-authored-by: Jiahao XU <[email protected]>

Update crates/binstalk-fetchers/src/signing.rs

f2bd890

Co-authored-by: Jiahao XU <[email protected]>

Update crates/binstalk-fetchers/src/signing.rs

5b97175

Co-authored-by: Jiahao XU <[email protected]>

Update crates/binstalk-fetchers/src/signing.rs

031b822

Co-authored-by: Jiahao XU <[email protected]>

Update crates/binstalk-fetchers/src/signing.rs

b562606

Co-authored-by: Jiahao XU <[email protected]>

fixes

0422bb9

Finish feature

3d10c84

Document

eaa68cc

passcod marked this pull request as ready for review September 6, 2023 08:31

passcod requested a review from NobodyXu September 6, 2023 08:31

Include all fields in the signing.file template

038635b

NobodyXu requested changes Sep 6, 2023

View reviewed changes

NobodyXu mentioned this pull request Sep 17, 2023

Update manifest taiki-e/install-action#228

Merged

NobodyXu requested changes Sep 23, 2023

View reviewed changes

e2e-tests/signing.sh Outdated Show resolved Hide resolved

passcod and others added 2 commits September 23, 2023 12:09

Update e2e-tests/signing.sh

1ec3e2d

Co-authored-by: Jiahao XU <[email protected]>

Merge branch 'main' into initial-signing-support

00d4521

NobodyXu added 11 commits September 23, 2023 10:44

Fix e2e-tests/signing.sh MacOS CI failure

c52fb74

Move the tls cert creation into `signing.sh` and sleep for 10s to wait for https server to start. Signed-off-by: Jiahao XU <[email protected]>

Refactor e2e-tests-signing files

cff9275

- Use a tempdir generated by `mktemp` for all certificates-related files - Put other checked-in files into `e2e-tests/signing` Signed-off-by: Jiahao XU <[email protected]>

Fixed e2e-tests-signing connection err in MacOS CI

c456530

Wait for server to start up by trying to connect to it. Signed-off-by: Jiahao XU <[email protected]>

Fix e2e-tests-signing passing -subj to openssl on Windows

40be0c9

Use single quote instead of double quote to avoid automatic expansion from bash Signed-off-by: Jiahao XU <[email protected]>

Fix e2e-tests-signing waiting for server to startup

40641a6

Remove `timeout` since it is not supported on MacOS. Signed-off-by: Jiahao XU <[email protected]>

Try to fix windows CI by setting MSYS_NO_PATHCONV=1 on openssl cmds

6188289

Signed-off-by: Jiahao XU <[email protected]>

Fixed e2e-tests-signing on windows

a12783c

By using double `//` for the value passed to option `-subj` Signed-off-by: Jiahao XU <[email protected]>

Fixed infinite loop in signing/wait-for-server on Windows

640b05d

Pass `--ssl-revoke-best-effort` to prevent schannel from checking ssl revocation status. Signed-off-by: Jiahao XU <[email protected]>

Add cap on retry attempt in signing/wait-for-server.sh

a7e03c3

Signed-off-by: Jiahao XU <[email protected]>

Let singing/server.py print output to stderr

c4bf310

so that we can see the error message there. Signed-off-by: Jiahao XU <[email protected]>

Fix running signing/server.py on MacOS CI

f7e0649

use `python3` since macos-latest still has python2 installed and `python` is a symlink to `python2` there. Signed-off-by: Jiahao XU <[email protected]>

NobodyXu approved these changes Sep 23, 2023

View reviewed changes

NobodyXu enabled auto-merge September 23, 2023 03:18

NobodyXu added this pull request to the merge queue Sep 23, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 23, 2023

NobodyXu added this pull request to the merge queue Sep 23, 2023

Merged via the queue into main with commit 32beba5 Sep 23, 2023

NobodyXu deleted the initial-signing-support branch September 23, 2023 04:16

This was referenced Sep 25, 2023

release: cargo-binstall v1.4.0 #1397

Merged

release: cargo-binstall v1.4.0 #1399

Merged

release: cargo-binstall v1.5.0 #1402

Closed

release: cargo-binstall v1.4.1 #1403

Merged

NobodyXu mentioned this pull request Sep 26, 2023

release: cargo-binstall v1.4.1 #1406

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial signing support #1345

Initial signing support #1345

passcod commented Sep 4, 2023

passcod commented Sep 4, 2023

NobodyXu commented Sep 23, 2023 •

edited

Loading

passcod commented Sep 23, 2023

Initial signing support #1345

Initial signing support #1345

Conversation

passcod commented Sep 4, 2023

passcod commented Sep 4, 2023

NobodyXu commented Sep 23, 2023 • edited Loading

passcod commented Sep 23, 2023

NobodyXu commented Sep 23, 2023 •

edited

Loading